feat: Implement restarter.stackable.tech/ignore label#410
Open
siegfriedweber wants to merge 10 commits intomainfrom
Open
feat: Implement restarter.stackable.tech/ignore label#410siegfriedweber wants to merge 10 commits intomainfrom
siegfriedweber wants to merge 10 commits intomainfrom
Conversation
4 tasks
siegfriedweber
added
release-note
…gmap.*" and "restarter.stackable.tech/ignore-secret.*"
sbernauer
changed the title
3 tasks
sbernauer
reviewed
Apr 10, 2026
Member
sbernauer
left a comment
sbernauer
left a comment
There was a problem hiding this comment.
Mostly nits, only one concern about the watcher and label
| authors = ["Stackable GmbH <info@stackable.tech>"] | ||
| license = "OSL-3.0" | ||
| edition = "2021" | ||
| edition = "2024" |
Member
There was a problem hiding this comment.
I would have preferred a separate PR (as part of stackabletech/issues#832), but I followed https://doc.rust-lang.org/edition-guide/editions/transitioning-an-existing-project-to-a-new-edition.html and ended up with nearly the same changes, so LGTM
|
|
||
| Label:: `restarter.stackable.tech/ignore` | ||
|
|
||
| If a ConfigMap or Secret is only used for initializing a StatefulSet or contains data which can be hot-reloaded, add the label `restarter.stackable.tech/ignore: "true"` to avoid unnecessary restarts of the StatefulSet pods: |
Member
There was a problem hiding this comment.
Suggested change
| If a ConfigMap or Secret is only used for initializing a StatefulSet or contains data which can be hot-reloaded, add the label `restarter.stackable.tech/ignore: "true"` to avoid unnecessary restarts of the StatefulSet pods: | |
| If a ConfigMap or Secret is only used for initializing a StatefulSet or contains data which can be hot-reloaded, add the label `restarter.stackable.tech/ignore: "true"` to avoid unnecessary restarts of the StatefulSet Pods: |
| metadata_watcher( | ||
| cms, | ||
| watcher::Config::default() | ||
| .labels("restarter.stackable.tech/ignore != true"), |
Member
There was a problem hiding this comment.
One thing that came up to my mind: What happens when users add or remove the label from a ConfigMap/Secret?
Will e.g. adding this label result in a stale version to be cached forever? Maybe this optimization is actually not worth it 🤷
Comment on lines
+295
to
+300
| .filter(|annotation| { | ||
| annotation | ||
| .0 | ||
| .starts_with("restarter.stackable.tech/ignore-configmap.") | ||
| }) | ||
| .map(|x| x.1) |
Member
There was a problem hiding this comment.
I misread .0 and .1 and was confused why we store the key. This is a idea how we could name them. Optional, feel free to ignore
(same below)
Suggested change
| .filter(|annotation| { | |
| annotation | |
| .0 | |
| .starts_with("restarter.stackable.tech/ignore-configmap.") | |
| }) | |
| .map(|x| x.1) | |
| .filter_map(|(key, value)| { | |
| key.starts_with("restarter.stackable.tech/ignore-configmap.") | |
| .then_some(value) | |
| }) |
Member
There was a problem hiding this comment.
Or as an alternative
Suggested change
| .filter(|annotation| { | |
| annotation | |
| .0 | |
| .starts_with("restarter.stackable.tech/ignore-configmap.") | |
| }) | |
| .map(|x| x.1) | |
| .filter(|(key, _)| key.starts_with("restarter.stackable.tech/ignore-configmap.")) | |
| .map(|(_, value)| value) |
|
|
||
| ### Added | ||
|
|
||
| - Support the annotation `restarter.stackable.tech/ignore` on ConfigMaps and Secrets and the |
Member
There was a problem hiding this comment.
Suggested change
| - Support the annotation `restarter.stackable.tech/ignore` on ConfigMaps and Secrets and the | |
| - Support the label `restarter.stackable.tech/ignore` on ConfigMaps and Secrets and the |
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support the
restarter.stackable.tech/ignoreannotation on ConfigMaps and Secrets to exclude them from the restarter controller.Rust edition updated to version 2024 to be able to use if-let-chains.
Part of stackabletech/issues#837
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker